Enable the usage of the NRLMSIS00 atmospheric model.#941
Merged
bcoconni merged 1 commit intoJSBSim-Team:masterfrom Jul 26, 2023
Merged
Enable the usage of the NRLMSIS00 atmospheric model.#941bcoconni merged 1 commit intoJSBSim-Team:masterfrom
bcoconni merged 1 commit intoJSBSim-Team:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 24.90% 24.89% -0.02%
==========================================
Files 168 168
Lines 18870 18887 +17
==========================================
+ Hits 4699 4701 +2
- Misses 14171 14186 +15
|
Member
|
Looks good. |
Contributor
|
Sounds good. Please go ahead with the merge step |
Member
Author
|
Thanks @seanmcleod and @agodemar. |
|
Hi, after these changes were merged, I was unable to build JSBSimForUnreal.sln. Got the error that FGMSISData.cpp was missing from src/models/atmosphere/. When I reverted, I was able to build. Thanks! |
Member
Author
|
@rickechler, this should now be fixed by the commit 8a807a7. |
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the last step to enable the MSIS atmospheric model in JSBSim (the previous PRs were #902, #908 and #916).
After this PR will be merged, the usage of the MSIS atmosphere will be triggered by the following XML code:
The XML can either be embedded in an aircraft definition file or supplied to
JSBSim.exevia the--planetoption or loaded with the C++ methodFGFDMExec::LoadPlanet()or the Python methodFGFDMExec.load_planet().At the moment the date shall be supplied as the day of the year, counting from Jan 1st which is day 1 to Dec 31st which is day 365. The time zone is UTC+00:00 and the time is supplied as the number of seconds elapsed since 00:00 (12:00AM).
This PR adds a test to
TestPlanet.pyto check that the pressure, density and temperature are computed by the MSIS model when the XML file above is supplied.