Use standard day SL density for VEAS in FGInitialCondition.#909
Merged
agodemar merged 1 commit intoJSBSim-Team:masterfrom May 10, 2023
Merged
Conversation
Member
|
Good catch. |
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 23.16% 23.15% -0.02%
==========================================
Files 167 167
Lines 19644 19639 -5
==========================================
- Hits 4551 4547 -4
+ Misses 15093 15092 -1
|
Member
Author
@agodemar If this PR looks good to you as well then I guess you can push the button 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the bug fix that has been released by @seanmcleod in PR #900, this PR applies the same fix to the
FGInitialConditionclass (it is not using the standard day SL density either for the computation of the equivalent airspeed).I took this opportunity to check that
FGAtmosphere::GetDensitySL()was not called elsewhere and remove the memberFGAtmosphere::in.DensitySLthat is no longer needed. In the process I also removed the memberFGAtmosphere::in.PressureSLwhich is not used anywhere.