Merged
Conversation
… working configuration but it won't mean much. But at least it will not genereate NaN's in the output file under any circumstance. Auto fix a user mistake where emtpy weigth > max weight.
…r everything was finished.
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
=======================================
Coverage 23.24% 23.24%
=======================================
Files 167 167
Lines 19603 19603
=======================================
Hits 4557 4557
Misses 15046 15046 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bcoconni
reviewed
Mar 22, 2023
3 tasks
bcoconni
pushed a commit
to bcoconni/jsbsim
that referenced
this pull request
Apr 8, 2023
* Fix a few expired links * Fix the case where all input parameters are undefined. You will get a working configuration but it won't mean much. But at least it will not genereate NaN's in the output file under any circumstance. Auto fix a user mistake where emtpy weigth > max weight. * Uncomment NaN signals for release builds * Embed the input parameters into the output file. * Introduce a warning system to display warning and alert messages after everything was finished.
bcoconni
pushed a commit
that referenced
this pull request
Sep 2, 2023
bcoconni
pushed a commit
to bcoconni/jsbsim
that referenced
this pull request
Sep 2, 2023
…generated ever. (JSBSim-Team#954)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden input handling and report warnings and alerts if something seems wrong.
This might fix #787. If not it could always be opened again.