Fix discovery of document version number#845
Merged
bcoconni merged 2 commits intoJSBSim-Team:masterfrom Mar 4, 2023
heshpdx:master
Merged
Fix discovery of document version number#845bcoconni merged 2 commits intoJSBSim-Team:masterfrom heshpdx:master
bcoconni merged 2 commits intoJSBSim-Team:masterfrom
heshpdx:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 22.43% 22.43%
=======================================
Files 167 167
Lines 19610 19608 -2
=======================================
Hits 4400 4400
+ Misses 15210 15208 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bcoconni
requested changes
Mar 4, 2023
Member
bcoconni
left a comment
There was a problem hiding this comment.
Overall looks good to me but I think the version variable declaration should now be located in the if (document->HasAttribute("version")) { block (see my review comments).
Move local variable to inner scope. Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
bcoconni
pushed a commit
to bcoconni/jsbsim
that referenced
this pull request
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code at
initialization/FGInitialCondition.cpp:1036is problematic for some newer compilers. I thinkversionwas coming back asinfor maybe-inf(I am not sure, it was not on my machine). Reports came in like this:I investigated and tried to figure the intent of the code. It feels like we should only check the version number if it was read in from the file, and otherwise just do a
Load_v1. I moved the block around and eliminated theif (version == HUGE_VAL)line which looked fishy (exact FP comparisons are usually not portable).