Remove the flag BASE from string_utilities.h#837
Merged
agodemar merged 6 commits intoJSBSim-Team:masterfrom Feb 13, 2023
Merged
Remove the flag BASE from string_utilities.h#837agodemar merged 6 commits intoJSBSim-Team:masterfrom
BASE from string_utilities.h#837agodemar merged 6 commits intoJSBSim-Team:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 22.37% 22.37%
=======================================
Files 168 167 -1
Lines 19535 19535
=======================================
Hits 4371 4371
Misses 15164 15164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Apr 8, 2023
* Remove the BASE flag. * Remove locale specific tests. * Code clean up * Fix DLL import for MinGW. * Further fixes for MinGW. * Simplify the build of unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reasons the file
string_utilities.hwas meant to be used both as a header and as a c++ source file. The flagBASEhad to be defined when the source code of the functions was to be compiled. Otherwise, whenBASEwas not defined, only the function signatures were used as if the file was a "pure" header file. This was like so since the filestring_utilities.hhad been included in JSBSim in June 2009.This PR is meant to remove this unusual process:
string_utilitiesis split into a pair of.hand.cppfiles just like the rest of the code base.string_utilities.hstring_utilities.cppBASEis removed from the code base.string_utilities.hare prepended byJSBSIM_APIto allow calling them in unit tests while JSBSim is compiled as a DLL.JSBSimnamespace to avoid name collisions with other libraries.