Avoid non physical values for the ambient pressure and temperature#836
Avoid non physical values for the ambient pressure and temperature#836agodemar merged 3 commits intoJSBSim-Team:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 22.37% 22.43% +0.05%
==========================================
Files 167 167
Lines 19535 19600 +65
==========================================
+ Hits 4371 4397 +26
- Misses 15164 15203 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
68220a0 to
637cd1d
Compare
|
Sorry @seanmcleod but I can't find your code review. Could you remind me what were the modifications that you were suggesting ? |
|
Hmm, I'll take a look, in the meantime this is what I see. It says Pending but I assumed that means it was pending feedback from you.
|
It seems it is pending for you according to the GitHub docs:
The last steps you need to follow are described in the GitHub docs: Submitting your review |
…SBSim-Team#836) * Validate input values to avoid NaNs and other silly behaviors. * Add tests for invalid input values * Add a test for the sea level pressure
This PR is addressing the bugs reported in the issue #815. As discussed, it caps pressure and temperature to small values:
JSBSim caps the pressure and temperature to the above mentioned values, issues an error message and continues execution.
I took this opportunity to add checks for other seting methods in
FGAtmosphereandFGStandardAtmosphere.