Locale independent numbers parsing#799
Merged
bcoconni merged 9 commits intoJSBSim-Team:masterfrom Dec 31, 2022
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 22.32% 22.37% +0.05%
==========================================
Files 167 168 +1
Lines 19484 19535 +51
==========================================
+ Hits 4349 4371 +22
- Misses 15135 15164 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ement as per Sean McLeod's suggestion.
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Dec 31, 2022
Fixes JSBSim-Team#795 Co-authored-by: Sean McLeod <sean@seanmcleod.com>
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Apr 8, 2023
Fixes JSBSim-Team#795 Co-authored-by: Sean McLeod <sean@seanmcleod.com>
This was referenced Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in issue #795, the calls to
atof()are replaced by a new functionatof_locale_cthat parses numbers assuming the decimal separator is the period.whatever is the current locale.The code uses
strtod_lthat is not part of the C/C++ standard however the code compiles on all platforms that JSBSim supports.