Skip to content

Synchronize CMake min version with the overall project.#1335

Merged
bcoconni merged 1 commit intoJSBSim-Team:masterfrom
bcoconni:upgrade_min_cmake_version
Sep 14, 2025
Merged

Synchronize CMake min version with the overall project.#1335
bcoconni merged 1 commit intoJSBSim-Team:masterfrom
bcoconni:upgrade_min_cmake_version

Conversation

@bcoconni
Copy link
Member

@bcoconni bcoconni commented Sep 13, 2025

With the release of CMake 4.0, compatibility with versions earlier than 3.5 is no longer supported. This PR updates the CMake minimum version requirement to 3.15 for the MSIS test that is run by our CI workflow.

Version 3.15 is already the minimum version required for the overall JSBSim project so this will not imply an upgrade for the developers or anyone compiling JSBSim from scratch:

cmake_minimum_required (VERSION 3.15)

@bcoconni
Copy link
Member Author

For the record, the files CMakeLists.txt and src/models/atmosphere/MSIS/CMakeLists.txt are the only CMake files who are calling the cmake_minimum_required command.

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.90%. Comparing base (f3f59eb) to head (ad2eeb3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
- Coverage   24.91%   24.90%   -0.02%     
==========================================
  Files         169      169              
  Lines       19675    19669       -6     
==========================================
- Hits         4902     4898       -4     
+ Misses      14773    14771       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bcoconni bcoconni merged commit ac3ec7c into JSBSim-Team:master Sep 14, 2025
29 checks passed
@bcoconni
Copy link
Member Author

Merged because the macos-latest platform appears to have migrated to CMake 4.0, which causes the CI workflow for PR #1336 to fail:

Run mkdir build && cd build
  mkdir build && cd build
  cmake ../src/models/atmosphere/MSIS
  shell: /bin/bash -e {0}
  env:
    release: false
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
-- Configuring incomplete, errors occurred!
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


Error: Process completed with exit code 1.

@bcoconni bcoconni deleted the upgrade_min_cmake_version branch September 14, 2025 11:30
bcoconni added a commit to bcoconni/jsbsim that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant