Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.76%. Comparing base (a222488) to head (4ab961c).
Report is 2 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   24.77%   24.76%   -0.01%     
==========================================
  Files         169      169              
  Lines       19598    19598              
==========================================
- Hits         4855     4854       -1     
- Misses      14743    14744       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Looks good. I see you're using some new C++17 constructs, init-statement in some of the if statements 😉

I guess no-one noticed the minimum dew point issue, since even the correct minimum dew point temperature is fairly close to absolute zero.

Looks good. I see you're using some new C++17 constructs, init-statement in some of the if statements 😉

Yep ! Thank you for letting me know about this feature 👍

I guess no-one noticed the minimum dew point issue, since even the correct minimum dew point temperature is fairly close to absolute zero.

Indeed but I figured this out while investigating this issue from FlightGear where users are complaining JSBSim is issuing too many console messages. It was incidental because it does not fix the issue but it is a bug anyway.

In addition, the FlightGear devs are concerned that I am submitting the fix to FlightGear before it is included in JSBSim. Hence this PR which will sync both code bases.

Yep ! Thank you for letting me know about this feature

Hmm, I'm a bit confused. When I looked at your commit I noticed the extra statements in some of the if statements, which I wasn't familiar with, so I took a look at the C++ standard https://en.cppreference.com/w/cpp/language/if and noticed:

init-statement | - | (since C++17)

So by using the init-statment option in the if statements you let me know about the feature, available from C++17, rather than the other way round.

you let me know about the feature, available from C++17, rather than the other way round.

No, no you mentioned it first: #1094 (comment) 😉 I remember that because your post made me make a mental note that this syntax could be convenient.

Aaaah, yes, you're right, my memory is fading 😉