Unify engine init logic; update TrimEnvelope limits#1267
Merged
bcoconni merged 1 commit intoJSBSim-Team:masterfrom Apr 23, 2025
Merged
Unify engine init logic; update TrimEnvelope limits#1267bcoconni merged 1 commit intoJSBSim-Team:masterfrom
bcoconni merged 1 commit intoJSBSim-Team:masterfrom
Conversation
Unified engine initialization logic across scripts by replacing individual engine settings with `propulsion/set-running = -1`. In `TrimEnvelope.py`: - Added variables for envelope limits (`min_speed`, `max_speed`, `altitude`, `min_gamma`, `max_gamma`). - Updated speed and gamma iteration to use these variables. - Made graph axis ranges dynamic based on envelope limits.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1267 +/- ##
=======================================
Coverage 24.78% 24.78%
=======================================
Files 169 169
Lines 19656 19656
=======================================
Hits 4872 4872
Misses 14784 14784 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
PR merged 👍 |
bcoconni
pushed a commit
to bcoconni/jsbsim
that referenced
this pull request
May 2, 2025
Co-authored-by: Sean McLeod <sean@seanmcleod.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified engine initialization logic across example scripts by replacing individual engine settings with
propulsion/set-running = -1.See discussion - #1264
In
TrimEnvelope.py:min_speed,max_speed,altitude,min_gamma,max_gamma).To make it easier for users switching between aircraft with quite varying flight envelopes, e.g. 737 versus a C172.