Reset turbulence vector when turbulence is disabled#1252
Reset turbulence vector when turbulence is disabled#1252bcoconni merged 2 commits intoJSBSim-Team:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 24.77% 24.77% -0.01%
==========================================
Files 169 169
Lines 19421 19423 +2
==========================================
Hits 4812 4812
- Misses 14609 14611 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/TestTurbulenceGustStop.py
Outdated
|
|
||
| self.checkBaselineWind(fdm) | ||
|
|
||
| def setup(self): |
There was a problem hiding this comment.
The name setup is almost colliding with the method JSBSimTestCase.setUp (note the capital U in setUp). I would suggest to either choose a different name or rename setup to setUp and inherit from JSBSimTestCase.setUp. Check the code from TestInputSocket.py below for an example:
jsbsim/tests/TestInputSocket.py
Lines 59 to 64 in e1ea4e8
If you choose renaming setup to setUp then please note that you will no longer need to make explicit calls to this method as setUp is automatically called before each test (i.e. before each method which name starts with test).
There was a problem hiding this comment.
Thanks, I'll take a look. Need to get more up to speed on the test framework 😉
There was a problem hiding this comment.
I've pushed a commit to update the test code to make use of the existing setUp() method.
Co-authored-by: Sean McLeod <sean@seanmcleod.com>
Fix the issue reported by - #1250 in terms of the turbulence effect not being reset when the turbulence was set to None.