Handle properly the exceptions returned by FGCondition#1244
Merged
bcoconni merged 2 commits intoJSBSim-Team:masterfrom Mar 12, 2025
Merged
Handle properly the exceptions returned by FGCondition#1244bcoconni merged 2 commits intoJSBSim-Team:masterfrom
bcoconni merged 2 commits intoJSBSim-Team:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 24.80% 24.77% -0.04%
==========================================
Files 169 169
Lines 19425 19425
==========================================
- Hits 4819 4812 -7
- Misses 14606 14613 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Mar 21, 2025
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor of
FGConditionmay throw exceptions of typeJSBSim::BaseExceptionwhen a<condition>element is improperly specified in the XML input files. The constructor ofFGConditionis called byFGScript::LoadScriptand the constructor ofFGDistributorbut none of them are handling properly the case where an exception is thrown byFGCondition:FGScript::LoadScriptexpects an exception of typestd::stringand therefore misses the deletion of the variablenewEventwhenFGConditionthrows an exceptionBaseException.FGDistributordoes not catch any exception thrown byFGConditionso the variablecurrent_caseis not deleted whenFGConditionthrows.These are 2 potential memory leaks that occur when JSBSim finds an error in a
<condition>element.Fixing these memory leaks have brought an opportunity to avoid the constructor of
FGConditionoutputting messages in the console. The error messages are now issued by the callers of the constructor ofFGConditionwhich saves passing the instance ofFGLoggerto the constructor ofFGCondition.