Make FGInertial::GetGM const#1175
Merged
bcoconni merged 1 commit intoJSBSim-Team:masterfrom Oct 26, 2024
Merged
Conversation
Member
|
Yep, can't see why it shouldn't. I've approved the workflow run to build and test in the meantime. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 25.12% 24.96% -0.17%
==========================================
Files 170 170
Lines 18337 19283 +946
==========================================
+ Hits 4608 4814 +206
- Misses 13729 14469 +740 ☔ View full report in Codecov by Sentry. |
Member
|
PR merged. Thanks @nsunderland1 for spotting this. |
bcoconni
pushed a commit
to bcoconni/jsbsim
that referenced
this pull request
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't think of any reason this shouldn't be const, it's a simple getter.