- Break confirmThenEnqueueMessage member function out of mainwindow.cpp#306
Conversation
and place it in a separate member function file in JS8_Mainwindow - Add UI hooks for Auto Reply confirmation back into the function - Remove redundant member function declarations from mainwindow.cpp that left over after moving the function to separate files, leaving only the function call sites - Move source file comments to the mainwindow header
wmiler
left a comment
There was a problem hiding this comment.
Thank you Chris, looks like that will do it.
|
Well, let it get run thru the wringer before we go with it. I took pieces of the old code that was removed, plus pieces of the new code, and tried to reconstruct it. So it needs to be verified that the two play nicely with one another. I inserted plenty of inline comments as I tried to figure it out, so if there's problems with it it should be fairly easy to diagnose. Having it buried in mainwindow.cpp - I didn't like that one. |
Joe-K0OG
left a comment
There was a problem hiding this comment.
@Chris-AC9KH I just built your 79a75d5, pr/AutoReplyConfirmation_fix, and tested it on both Linux and Windows, and the notifications now work with all the message types that it should, generating the pop-up when the "Ask for confirmation..." check box is ticked. This works for HB ACKs, MSGs, ">" forwarding (with and without subsequent callsign).
This one is good to go - thanks!
73,
-Joe-
K0OG
|
We have the required number of approvals on it so I'll merge this. I didn't test the API part but assume it works. If somebody has a network client, or connects to it with command line, and finds something wrong with it, this PR should not have broken anything with that. I took care to make sure the two can cancel each other out via timer. But whether or not the notification actually gets transmitted by API or network, I' don't know. |
On Linux when I test, I run a UDP client during testing (it is a mapper), and it works fine with your code. 73, |
|
@Joe-K0OG the issue here would be whether or not the notification goes out over network. It should because I didn't change any functionality of the previous commit that removed the UI part of it, except adding the hooks to the UI back in. I'm not sure what the thinking was with that, or even if there was any thinking, because some AI bot did it. |
@Chris-AC9KH I think I see what you are looking for. I connected to JS8Call TCP port with telnet, enabled autoreply confirmation, and indeed see the autoreply notification via the TCP port simultaneous with the confirmation pop-up window, so I think all is good. Here is an example: Is that what you were looking for? 73, |
|
,"type":"STATION.AUTOREPLY_CONFIRM_REQUEST" yep, there it is. So it all works. Thanks! |
and place it in a separate member function file in JS8_Mainwindow
Fixes #305