Skip to content

- Break confirmThenEnqueueMessage member function out of mainwindow.cpp#306

Merged
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/AutoReplyConfirmation_fix
May 24, 2026
Merged

- Break confirmThenEnqueueMessage member function out of mainwindow.cpp#306
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/AutoReplyConfirmation_fix

Conversation

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

and place it in a separate member function file in JS8_Mainwindow

  • Add UI hooks for Auto Reply confirmation back into the function
  • Remove redundant member function declarations from mainwindow.cpp that left over after moving the function to separate files, leaving only the function call sites
  • Move source file comments to the mainwindow header

Fixes #305

and place it in a separate member function file in JS8_Mainwindow
- Add UI hooks for Auto Reply confirmation back into the function
- Remove redundant member function declarations from mainwindow.cpp that
left over after moving the function to separate files, leaving only the
function call sites
- Move source file comments to the mainwindow header

@wmiler wmiler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Chris, looks like that will do it.

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

Well, let it get run thru the wringer before we go with it. I took pieces of the old code that was removed, plus pieces of the new code, and tried to reconstruct it. So it needs to be verified that the two play nicely with one another. I inserted plenty of inline comments as I tried to figure it out, so if there's problems with it it should be fairly easy to diagnose. Having it buried in mainwindow.cpp - I didn't like that one.

@Joe-K0OG Joe-K0OG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chris-AC9KH I just built your 79a75d5, pr/AutoReplyConfirmation_fix, and tested it on both Linux and Windows, and the notifications now work with all the message types that it should, generating the pop-up when the "Ask for confirmation..." check box is ticked. This works for HB ACKs, MSGs, ">" forwarding (with and without subsequent callsign).

This one is good to go - thanks!

73,
-Joe-
K0OG

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

We have the required number of approvals on it so I'll merge this. I didn't test the API part but assume it works. If somebody has a network client, or connects to it with command line, and finds something wrong with it, this PR should not have broken anything with that. I took care to make sure the two can cancel each other out via timer. But whether or not the notification actually gets transmitted by API or network, I' don't know.

@Chris-AC9KH Chris-AC9KH merged commit f03d69e into JS8Call-improved:master May 24, 2026
8 checks passed
@Chris-AC9KH Chris-AC9KH deleted the pr/AutoReplyConfirmation_fix branch May 24, 2026 21:16
@Joe-K0OG

Copy link
Copy Markdown
Collaborator

I didn't test the API part but assume it works. If somebody has a network client,

On Linux when I test, I run a UDP client during testing (it is a mapper), and it works fine with your code.

73,
-Joe-
K0OG

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

@Joe-K0OG the issue here would be whether or not the notification goes out over network. It should because I didn't change any functionality of the previous commit that removed the UI part of it, except adding the hooks to the UI back in. I'm not sure what the thinking was with that, or even if there was any thinking, because some AI bot did it.

@Joe-K0OG

Copy link
Copy Markdown
Collaborator

@Joe-K0OG the issue here would be whether or not the notification goes out over network. It should because I didn't change any functionality of the previous commit that removed the UI part of it, except adding the hooks to the UI back in. I'm not sure what the thinking was with that, or even if there was any thinking, because some AI bot did it.

@Chris-AC9KH I think I see what you are looking for. I connected to JS8Call TCP port with telnet, enabled autoreply confirmation, and indeed see the autoreply notification via the TCP port simultaneous with the confirmation pop-up window, so I think all is good. Here is an example:

FHG: KB5VKB HEARTBEAT SNR -10 "}
{"params":{"CMD":" HEARTBEAT","DIAL":7077998,"EXTRA":"","FREQ":7080301,"FROM":"KE4ZDJ","GRID":"EM87","OFFSET":2303,"SNR":-9,"SPEED":0,"TDRIFT":0.17500001192092896,"TEXT":"@HB HEARTBEAT ◊ ","TO":"@HB","UTC":1779666957309,"_ID":-1},"type":"RX.DIRECTED","value":"@HB HEARTBEAT ◊ "}
{"params":{"CONFIRM_ID":1,"OFFSET":-1,"PRIORITY":11,"TIMEOUT":90,"_ID":-1},"type":"STATION.AUTOREPLY_CONFIRM_REQUEST","value":"KE4ZDJ HEARTBEAT SNR -09"}
{"params":{"CMD":" HEARTBEAT SNR","DIAL":7077998,"EXTRA":"-13","FREQ":7080526,"FROM":"KC5CQW","GRID":"","OFFSET":2528,"SNR":-24,"SPEED":0,"TDRIFT":0.06000000238418579,"TEXT":"KB5VKB HEARTBEAT SNR -13 ◊ ","TO":"KB5VKB","UTC":1779666957337,"_ID":-1},"type":"RX.DIRECTED","value":"KB5VKB HEARTBEAT SNR -13 ◊ "}

Is that what you were looking for?

73,
-Joe-
K0OG

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

,"type":"STATION.AUTOREPLY_CONFIRM_REQUEST" yep, there it is. So it all works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ask for Confirmation before Sending Autoreply is Broken

3 participants