Fix for #298 - APRS CMD not checksumming properly. #300
Conversation
|
@punk-kaos GREAT! I'm building now. This needs to be fixed for SMS messages too, so I'll try to test for that as well. 73, |
|
@punk-kaos I built and tested your fix on Linux and Windows, and find it works perfectly for APRSIS email, SMS, and APRS messages, properly appending checksums to all three. I was also able to send an email via APRSIS EMAIL-2. I think this is ready to push to the official main repo. Maybe @Chris-AC9KH should test it on MacOS? 73, |
My test platform is MacOS so it works there, at least for me. Wouldn't hurt for Chris to test too though. |
|
I won't bother with testing on this one. Been busy getting the Windows workflow builds working again. And that ended up being major because I scrapped MSYS2/gcc and switched it to Clang 17. I didn't actually PR it or merge. I just developed it. It's up to Wyatt to integrate it into the workflow because that's his dept. |
That's fine @Chris-AC9KH since @punk-kaos tested it on his Mac. I think we are good. It wasn't a major change, just a little bug fix. @punk-kaos I think you can proceed with the push. 73, |
I don't think I have push approval, Chris or Wyatt will have to do the final push I believe. |
|
merged. Thanks Kelly! |
|
Thanks @Chris-AC9KH Chris and @punk-kaos Kelly - these kind of fixes are SWEET! 73, |
This fixes a regression where APRS CMDs don't properly checksum when transmitting.