Skip to content

Fix for #298 - APRS CMD not checksumming properly. #300

Merged
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
punk-kaos:fix/aprs-checksum-msg-only
May 20, 2026
Merged

Fix for #298 - APRS CMD not checksumming properly. #300
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
punk-kaos:fix/aprs-checksum-msg-only

Conversation

@punk-kaos

Copy link
Copy Markdown
Collaborator

This fixes a regression where APRS CMDs don't properly checksum when transmitting.

@Joe-K0OG

Copy link
Copy Markdown
Collaborator

@punk-kaos GREAT! I'm building now. This needs to be fixed for SMS messages too, so I'll try to test for that as well.

73,
-Joe-
K0OG

@Joe-K0OG

Copy link
Copy Markdown
Collaborator

@punk-kaos I built and tested your fix on Linux and Windows, and find it works perfectly for APRSIS email, SMS, and APRS messages, properly appending checksums to all three. I was also able to send an email via APRSIS EMAIL-2. I think this is ready to push to the official main repo. Maybe @Chris-AC9KH should test it on MacOS?

73,
-Joe-
K0OG

@punk-kaos

Copy link
Copy Markdown
Collaborator Author

@punk-kaos I built and tested your fix on Linux and Windows, and find it works perfectly for APRSIS email, SMS, and APRS messages, properly appending checksums to all three. I was also able to send an email via APRSIS EMAIL-2. I think this is ready to push to the official main repo. Maybe @Chris-AC9KH should test it on MacOS?

73, -Joe- K0OG

My test platform is MacOS so it works there, at least for me. Wouldn't hurt for Chris to test too though.

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

I won't bother with testing on this one. Been busy getting the Windows workflow builds working again. And that ended up being major because I scrapped MSYS2/gcc and switched it to Clang 17. I didn't actually PR it or merge. I just developed it. It's up to Wyatt to integrate it into the workflow because that's his dept.

@Joe-K0OG

Copy link
Copy Markdown
Collaborator

I won't bother with testing on this one.

That's fine @Chris-AC9KH since @punk-kaos tested it on his Mac. I think we are good. It wasn't a major change, just a little bug fix.

@punk-kaos I think you can proceed with the push.

73,
-Joe-
K0OG

@Joe-K0OG Joe-K0OG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one - tests good, simple fix.

Thanks @punk-kaos!

73,
-Joe-
K0OG

@punk-kaos

Copy link
Copy Markdown
Collaborator Author

I won't bother with testing on this one.

That's fine @Chris-AC9KH since @punk-kaos tested it on his Mac. I think we are good. It wasn't a major change, just a little bug fix.

@punk-kaos I think you can proceed with the push.

73, -Joe- K0OG

I don't think I have push approval, Chris or Wyatt will have to do the final push I believe.

@Chris-AC9KH Chris-AC9KH merged commit 8bee47e into JS8Call-improved:master May 20, 2026
4 checks passed
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

merged. Thanks Kelly!

@punk-kaos punk-kaos deleted the fix/aprs-checksum-msg-only branch May 20, 2026 03:56
@Joe-K0OG

Copy link
Copy Markdown
Collaborator

Thanks @Chris-AC9KH Chris and @punk-kaos Kelly - these kind of fixes are SWEET!

73,
-Joe-
K0OG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants