PSK Reporter Bug Fixes#29
Merged
Chris-AC9KH merged 1 commit intoNov 11, 2025
Merged
Conversation
bazineta
reviewed
Nov 10, 2025
bazineta
left a comment
Contributor
There was a problem hiding this comment.
Bands appears to be a leak; perhaps use one of the smart pointers to hold on to it?
b9aa591 to
ab18cd6
Compare
Updates callsign cache to be band-aware Fixes callsign cache timeout logic Extends callsign cache expiration to 1 hour (formerly 5 minutes) Adds randomness to reporting interval Removes mystery 49 MHz+ cache bypass inherited from WSJTX
ab18cd6 to
0ddcd40
Compare
Collaborator
Author
|
Good catch, I didn't realize it's already available on the configuration. |
bazineta
reviewed
Nov 10, 2025
bazineta
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me now.
bazineta
approved these changes
Nov 11, 2025
Collaborator
|
Merged. Thanks! |
| // If this call is not already in the cache, or it's there but expired, or the | ||
| // frequency is interesting, or an eclipse is active, (we allow all spots through | ||
| // +/- 6 hours around an eclipse for the HamSCI group) then we're going to send | ||
| // If this call is not already in the cache, or it's there but expired, or an eclipse is active, |
Collaborator
There was a problem hiding this comment.
If this call+band combination is not ...
Collaborator
|
Didn't pay attention: Commented on an already merged PR. Sorry about the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #9
Updates callsign cache to be band-aware
Fixes callsign cache timeout logic
Extends callsign cache expiration to 1 hour (formerly 5 minutes)
Adds randomness to reporting interval
Removes mystery 49 MHz+ cache bypass inherited from WSJTX