Skip to content

Reporting to PSK reporter: Several bugs. #9

Description

@aknrdureegaesr
  • In their documentation, PSK reporter asks the same call should not be reported twice in the same hour unless there's been a significant change. Our code will report the same call once every 5 minutes. Or at least that is what it tries to do.
  • What it actually does: There is a trivial bug causing the present code to check whether the cache entry is younger than 300 seconds into the epoch. If so, it is considered old enough to be ignored.
  • Also, the present code does not remember the band of the observation. So if several people change bands together, they will not report each other before the respective cache entries expire.
  • The PSK reporter documentation suggests to add randomness to the sending interval. This is not done.
  • I have seen it happen that PSK reporter did not report, in my name, stations that I've heard. Trying to find the place in the code that caused this resulted in the other findings.

Mildly related attempt at humor

Part of this reminds me of a coveted industry joke:

There are four hard things in IT:

  • Coming up with good names.
  • Cache invalidation.
  • Counting.

(I've seen all of these problems in the present code.)

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions