Improve the documentation of JS8Submode.hpp.#2
Conversation
|
@bazineta Allan, when you get a chance could you glance thru this? It looks ok to me. |
Thanks, Chris 🌹! Just a random remark with no direct consequences: We have not decided on the merge rules yet. But if they were in place as suggested (and if we understand "looks ok to me" as equivalent to "looks good to me"), this would mean approval count is now 1 and the PR could be merged starting Tuesday, 2025-10-27 21:18 UTC , even if Allan does not react by then. |
|
This looks excellent. This particular TU originated as an extraction of these concepts from being littered everywhere in the 2.2.0 codebase and landing them in one place and one place only for 2.3.0, so yes, no argument that it could have been done better; I was at the time trying not to break anything in the process, and so didn't give much thought to the naming. |
|
Merged. Thanks! |
Add Doxygen output directory to .gitignore
The present
JS8Submode.hppmakes it unnecessarily hard to understand what is going on.The net result is a hurdle for (new) developers to join the project and contribute.
This PR improves the situation.