@wmiler yes, this one could be picked for a 2.5.1 patch release, and would justify the patch release. This evening when I get time, I will do that and add the reason for the patch release to the release notes. Now that we have auto software update working, it will be trivial to push a patch release for it.

Merged. Thanks Rob!

@wmiler when I get the patch release ready, and the branch updated, I'll notify so you can run the builds for it. MacOS builds might take awhile, depending on how fast Apple gets me back notarization tickets for it.

@wmiler I created a release/2.5.1 branch with this fix cherry-picked into it. And have a draft release for it. I'll get MacOS builds going right away and get those sent to Apple. As soon as the run completes on that branch let me know where the Windows and Linux builds are and I'll get those uploaded. If the MacOS ones take longer than I expect it is no big deal and I'll put them there later. Apple's notarization team SHOULD be fully staffed after the holidays so I expect it to go pretty fast.

@rruchte just testing the Mac builds for the 2.5.1 patch release. The Saved Messages dialog actually meets the Mac UI standards now for dark mode. I never use dark mode so I never really looked at it before, but that one was pretty unbelievable :-)

Got the universal build thru Cupertino before quittin' time. Trying to squeeze the Apple silicon build thru before they all pack up and go home and leave one poor person there handling notarizations over night!

@Chris-AC9KH for some reason it's not signing the windows installer when built from the release/2.5.1 branch. Not sure why 🤷🏻‍♂️ I noticed it was doing that on the release/2.5.0 branch as well. Works fine from master and PRs. You should be ok to just sign it from a windows box.

If I actually knew how to sign it from Windows. Which I don't. I fuddled my thru making a certificate and key but not sure how to use it :-)

The release/2.5.0 build is signed. I uploaded that to the virus total and it said it was signed by the JS8Call Developers.

I just checked the arm64 build running in the VM on the Mac with Debian 13. That works fine.

Ok, so I got arm64 Windows 11 running on the Mac. But I'll have to read the documentation on how to use codesign.exe. I did this once when I was fiddling around when we were discussing code signing on Windows, did a build with Qt Creator and it used the Visual Studio tools to sign my build. And it worked.

I'll have to re-trace my steps on that.

Well, let's just say Windows is not really usable. I found my installed certificates, I just have to figure out how to use the signtool. And I have to remember what the private key password is to it, which I think was CodeSigningTest.

Let's just say this is an interesting experience.

Ok, I'll get it signed by lunch then, just have to turn that machine back on again...

I think I got it. The first time failed because Windows did a sudden restart and dropped to a black screen that said updates are underway, don't turn off your PC. That took (I think it was) three reboots and I finally got to the desktop again but everything was gone. Windows apparently doesn't save your open work when you log out or shut it down like MacOS.

So I had to re-figure out the command I was trying to put together in Windows Power Shell. I finally got it to say it successfully signed it. I uploaded it to virustotal and it says it's signed. So I uploaded it to the release assets for 2.5.1. That should be ready to go, I'll just publish it after I test the installer here on Windows 11.

Ok. I still need to figure out why I can't get it to read the secrets from a branch. I'll stick that on list of stuff to do, because it's annoying. :)

The installer works, Windows Defender had no issues with it. The program runs fine. So I'll publish that patch release. I just put minimal release notes in for it, explaining the reason for the patch release. But it will create a release/2.5.1 tag on publish.