Windows self-signed#116
Merged
Merged
Conversation
Added steps for code signing and certificate handling in CI workflow.
Make this a bit more production ready. Hide the cert pass in a github secret.
Collaborator
Author
|
This should work correctly when it gets merged, github doesn't like sharing secrets to forked repos (with good cause), which is why it's failing to get the secrets. |
Chris-AC9KH
pushed a commit
that referenced
this pull request
Jan 3, 2026
* Fix icon directory setup for AppImage workflow * Add application icon to Windows installer script * Add StartupWMClass to JS8Call.desktop * Implement code signing in CI for Windows builds Added steps for code signing and certificate handling in CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of self-signed certs for testing, do NOT use for production builds.
Other minor CI fixes.