Merged
Conversation
|
Hi! I tested your PR. I think you also need to replace the |
yueryang
approved these changes
Dec 30, 2024
Contributor
yueryang
left a comment
There was a problem hiding this comment.
Thank you for the nice update. I used this version to build the Python charm for Python 3.12 and it worked fine. I have been using this version with Python 3.12 under the Ubuntu (24.04.1 LTS) operating system (WSL) for over a month. Everything seems pretty. Testing schemes work correctly. It is my sincere hope that this branch can be merged. Merry Christmas and Happy New Year.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to reflect changes in cython 3.11 and 3.12, mainly PEP 674 and python/cpython#101292