Fix Issue #326: Adapt to PyLongObject changes in Python 3.12+#328
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Jun 19, 2025
Merged
Fix Issue #326: Adapt to PyLongObject changes in Python 3.12+#328jakinyele merged 1 commit intoJHUISI:devfrom
jakinyele merged 1 commit intoJHUISI:devfrom
Conversation
In Python 3.12 and newer, the `PyLongObject` struct was changed, making `Py_SIZE()` unreliable for getting the length of the digit array. The following changes have been implemented: 1. Introduced `PyLongObj_Size` macro to calculate the size of `PyLongObject` struct. 2. Renamed `PythonLongVal` to `PyLongObj_Val` to improve naming consistency. **Note**: Further adjustments may be required for Python 3.14+ due to potential shifts to new C APIs, as detailed in PEP 757.
Contributor
|
Hi, guys. Thank you so much for fixing those issues in ZR. |
Contributor
Author
|
@BatchClayderman Don't worry, this is normal and depends on the implementation of the |
jakinyele
approved these changes
Jun 19, 2025
Member
jakinyele
left a comment
There was a problem hiding this comment.
This is a good catch. Thanks for the PR @Komorebi-Z.
This was referenced Jun 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.12 and newer, the
PyLongObjectstruct was changed, makingPy_SIZE()unreliable for getting the length of the digit array. This issue causedlongObjToMPZ()to incorrectly determine the length oflong_objduring the initialization functionElement_elem()in charm/core/math/pairing/pairingmodule.c, leading to incorrect conversion behavior.The following changes have been implemented:
PyLongObj_Sizemacro to calculate the size ofPyLongObjectstruct.PythonLongValtoPyLongObj_Valto improve naming consistency.This probably fixes issue #326, but further testing on different Python versions is recommended for caution.
Note: Further adjustments may be required for Python 3.14+ due to potential shifts to new C APIs, as detailed in PEP 757.