Fix workflow configurations, PHP compatibility issues, and language key conventions#1393
Merged
nielsdrost7 merged 4 commits into1017-feature-request-add-option-to-add-pdf417-barcode-to-invoicefrom Jan 19, 2026
Conversation
7 tasks
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update PDF417Barcode implementation based on review feedback
Fix workflow configurations, PHP compatibility issues, and language key conventions
Jan 19, 2026
ce3f649
into
1017-feature-request-add-option-to-add-pdf417-barcode-to-invoice
1 check passed
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
nielsdrost7
added a commit
that referenced
this pull request
Jan 19, 2026
…ey conventions (#1393) * Initial plan * Fix workflow issues: update triggers, commands, and validation logic Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix PHP compatibility and security issues in helpers and enum Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Rename PDF 417 barcode language keys and make labels generic Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #1238 covering workflow misconfigurations, PHP 8.4+ compatibility issues, security vulnerabilities, and language key naming violations.
Workflow Fixes
composer.lockandcomposer.jsonfor changes; parseadvisoriesarray instead of checking file sizedocker-compose(v1) withdocker compose(v2)pull_requesttrigger to enable PR comments--dirtywith git diff-based file detection (actions/checkout produces clean tree)artisan migrate); use CodeIgniter configapplication/language/englishinstead ofresources/lang/enyarn.lockandpackage.jsonfor changesPHP Compatibility & Security
file_security_helper.php: Replace
mb_rtrim()withrtrim()(PHP 8.4+ function):mailer_helper.php: Fix referer validation host spoofing vulnerability:
ClientTitleEnum.php: Fix
tryFrom()false-positive on index 0:Language Key Refactoring
Rename
'417_barcode_*'→'pdf_417_barcode_*'(12 keys) to follow text-prefix convention. Update labels to be country-agnostic:'417_barcode_settings_enable': "Enable PDF 417 Barcode for croatian clients" → "Enable PDF 417 Barcode"'417_barcode_settings_enable_hint': Remove country reference while keeping technical requirementsUpdated 44 references in
partial_settings_invoices.php(settings form fields, labels, trans() calls).💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.