[IP-1083]: Add pagination for tabs in client detail#1084
Merged
nielsdrost7 merged 6 commits intodevelopmentfrom Oct 30, 2024
Merged
[IP-1083]: Add pagination for tabs in client detail#1084nielsdrost7 merged 6 commits intodevelopmentfrom
nielsdrost7 merged 6 commits intodevelopmentfrom
Conversation
Contributor
Author
|
@nielsdrost7 I don't know if this is the right way to integrate pagination, but I test it and it works. If you have some corrections, I will do it. |
Contributor
|
@pumpi I'm a bit worried about that |
Contributor
Author
|
Yeah no problem it was the simplest solution for me but I think is not the best 🙈 |
naui95
approved these changes
Sep 29, 2024
Contributor
naui95
left a comment
There was a problem hiding this comment.
$tab solution works for me. We do not have any ajax pagination in IPv1 so that the provided solution is consistent with the project. I changed how we handle the "tab change event". The change made front-end with js had the problem that with the $tab solution the url did not match the current selection. To prevent this mismatch all tab clicks are now routing events.
Contributor
Author
|
I have seen a styling issue last week. If you have a small display and must scroll to the pagination there is no space at the end of the page, this shows ugly. I wanted to fix it but couldn't find the time. I hope to have a few minutes next week. For the naming of |
Contributor
Ok, thank you. I will put it on hold and wait for your integration before merging. Please remember to pull before starting with your edits ;) |
Contributor
|
Hi @pumpi do you have time to finish your PR? We would like to pull the solution in the next version. If not, I can check that design issue you mentioned. |
Contributor
Author
|
No sorry no time the last weeks. I'll do it tomorrow I promise. When are you planing the next release? |
Contributor
beta release is planned for mid November (latest). If we get there before, then better :) |
Contributor
Author
|
@naui95 I have added a bottom space to |
nielsdrost7
approved these changes
Oct 30, 2024
Merged
nielsdrost7
added a commit
that referenced
this pull request
Dec 30, 2024
## New Contributors Huge thanks to @sudwebdesign , @xam-ps and @AeroBytesNL for helping. Without you guys this release wouldn't have been possible * @sudwebdesign made their first contribution in #1149 * @VizardAlpha made their first contribution in #1129 * @pumpi made their first contribution in #1079 * @jmclaren7 made their first contribution in #1013 * @RobiNN1 made their first contribution in #1014 * @xeruf made their first contribution in #1061 * @NiklasSchmitt made their first contribution in #1073 * @redxtech made their first contribution in #1098 ## What's Changed * Add buttons on client view to delete note (Ajax) by @sudwebdesign in #1149 * Translate Client "Extra Field Title" to complete #1003 by @sudwebdesign in #1150 * [IP-1146]: after posting a Payments Form when amount > inv. total by @sudwebdesign in #1151 * [IP-1147]: Fix setup sql filenames by @sudwebdesign in #1152 * [IP-1130]: Added required input check on full page loaded to fix #1130 by @AeroBytesNL in #1155 * bug-fix-#1147-error-on-database-migration by @AeroBytesNL in #1159 * Fix setup Red Screen Of Death with bad DB query by @sudwebdesign in #1160 * **[IP-1128]**: Update QrCode.php wrong variable by @VizardAlpha in #1129 * Improve download function in #1127 * Chore: Fix upload_file function in #1141 * Show list of themes on Windows by @RobiNN1 in #1014 * [IP-1038]: Fix for issue 1038: Wrong translation string in setup by @naui95 in #1039 * [IP-1012]: Revert change to invoice_logo() by @jmclaren7 in #1013 * Slight improvements to README.md by @xeruf in #1061 * [IP-1070] by @naui95 in #1071 * [IP-1072] Fixed broken customer-link in projects-widget on dashboard. by @NiklasSchmitt in #1073 * [IP-1078]: ZUGFeRD Name should not be user name by @pumpi in #1079 * [IP-1006]: feature: payments v1.6.2 by @naui95 in #1046 * added information on theming by @naui95 in #1087 * [IP-1097]: add docker publish workflow by @redxtech in #1098 * [IP-841]: Copy Quote UI feedback by @Verony-makesIT in #932 * [IP-998]: copy all fields available in quotes by @naui95 in #1086 * [IP-1083]: Add pagination for tabs in client detail by @pumpi in #1084 * [IP-731]: Add another digit for quantity (new version) by @naui95 in #1112 * [IP-1003]: Add extra field title by nielsdrost7 in #1101 * add function to check post variables by nielsdrost7 in #1090 * [IP-1096] Payments array variable gets lost for invoices by nielsdrost7 in #1104 * Chore: add pint by nielsdrost7 in #1081 * [IP-1033] creation dates of invoices should never be changed by nielsdrost7 in #1040 * [IP-1034]: Fix error where default_language at some point switches to English by nielsdrost7 in #1035 * Make sure we don't get unintended output in our PDF files by nielsdrost7 in #1089 * [IP-1010]: Add php-dom and php-xml to the Dockerfile by nielsdrost7 in #1110 * Special project by nielsdrost7 in #1120 * [IP-1063]: Allowing for Dynamic Properties (**PHP 8.2**) by nielsdrost7 in #1117 Co-authored-by: Thomas Ingles Co-authored-by: AutiCodes Co-authored-by: AeroBytes Co-authored-by: naui95 Co-authored-by: VeRony Co-authored-by: Marc Heiduk Co-authored-by: Róbert Kelčák Co-authored-by: John Mclaren Co-authored-by: Janek Co-authored-by: Niklas Co-authored-by: stephan4p Co-authored-by: pumpi Co-authored-by: der-peer Co-authored-by: Nathan Mattes Co-authored-by: Kevin Joudrier Co-authored-by: Gabe Dunn Co-authored-by: VizardAlpha
ThierryHFR
pushed a commit
to ThierryHFR/InvoicePlane
that referenced
this pull request
Dec 21, 2025
Huge thanks to @sudwebdesign , @xam-ps and @AeroBytesNL for helping. Without you guys this release wouldn't have been possible * @sudwebdesign made their first contribution in InvoicePlane#1149 * @VizardAlpha made their first contribution in InvoicePlane#1129 * @pumpi made their first contribution in InvoicePlane#1079 * @jmclaren7 made their first contribution in InvoicePlane#1013 * @RobiNN1 made their first contribution in InvoicePlane#1014 * @xeruf made their first contribution in InvoicePlane#1061 * @NiklasSchmitt made their first contribution in InvoicePlane#1073 * @redxtech made their first contribution in InvoicePlane#1098 * Add buttons on client view to delete note (Ajax) by @sudwebdesign in InvoicePlane#1149 * Translate Client "Extra Field Title" to complete InvoicePlane#1003 by @sudwebdesign in InvoicePlane#1150 * [IP-1146]: after posting a Payments Form when amount > inv. total by @sudwebdesign in InvoicePlane#1151 * [IP-1147]: Fix setup sql filenames by @sudwebdesign in InvoicePlane#1152 * [IP-1130]: Added required input check on full page loaded to fix InvoicePlane#1130 by @AeroBytesNL in InvoicePlane#1155 * bug-fix-InvoicePlane#1147-error-on-database-migration by @AeroBytesNL in InvoicePlane#1159 * Fix setup Red Screen Of Death with bad DB query by @sudwebdesign in InvoicePlane#1160 * **[IP-1128]**: Update QrCode.php wrong variable by @VizardAlpha in InvoicePlane#1129 * Improve download function in InvoicePlane#1127 * Chore: Fix upload_file function in InvoicePlane#1141 * Show list of themes on Windows by @RobiNN1 in InvoicePlane#1014 * [IP-1038]: Fix for issue 1038: Wrong translation string in setup by @naui95 in InvoicePlane#1039 * [IP-1012]: Revert change to invoice_logo() by @jmclaren7 in InvoicePlane#1013 * Slight improvements to README.md by @xeruf in InvoicePlane#1061 * [IP-1070] by @naui95 in InvoicePlane#1071 * [IP-1072] Fixed broken customer-link in projects-widget on dashboard. by @NiklasSchmitt in InvoicePlane#1073 * [IP-1078]: ZUGFeRD Name should not be user name by @pumpi in InvoicePlane#1079 * [IP-1006]: feature: payments v1.6.2 by @naui95 in InvoicePlane#1046 * added information on theming by @naui95 in InvoicePlane#1087 * [IP-1097]: add docker publish workflow by @redxtech in InvoicePlane#1098 * [IP-841]: Copy Quote UI feedback by @Verony-makesIT in InvoicePlane#932 * [IP-998]: copy all fields available in quotes by @naui95 in InvoicePlane#1086 * [IP-1083]: Add pagination for tabs in client detail by @pumpi in InvoicePlane#1084 * [IP-731]: Add another digit for quantity (new version) by @naui95 in InvoicePlane#1112 * [IP-1003]: Add extra field title by nielsdrost7 in InvoicePlane#1101 * add function to check post variables by nielsdrost7 in InvoicePlane#1090 * [IP-1096] Payments array variable gets lost for invoices by nielsdrost7 in InvoicePlane#1104 * Chore: add pint by nielsdrost7 in InvoicePlane#1081 * [IP-1033] creation dates of invoices should never be changed by nielsdrost7 in InvoicePlane#1040 * [IP-1034]: Fix error where default_language at some point switches to English by nielsdrost7 in InvoicePlane#1035 * Make sure we don't get unintended output in our PDF files by nielsdrost7 in InvoicePlane#1089 * [IP-1010]: Add php-dom and php-xml to the Dockerfile by nielsdrost7 in InvoicePlane#1110 * Special project by nielsdrost7 in InvoicePlane#1120 * [IP-1063]: Allowing for Dynamic Properties (**PHP 8.2**) by nielsdrost7 in InvoicePlane#1117 Co-authored-by: Thomas Ingles Co-authored-by: AutiCodes Co-authored-by: AeroBytes Co-authored-by: naui95 Co-authored-by: VeRony Co-authored-by: Marc Heiduk Co-authored-by: Róbert Kelčák Co-authored-by: John Mclaren Co-authored-by: Janek Co-authored-by: Niklas Co-authored-by: stephan4p Co-authored-by: pumpi Co-authored-by: der-peer Co-authored-by: Nathan Mattes Co-authored-by: Kevin Joudrier Co-authored-by: Gabe Dunn Co-authored-by: VizardAlpha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add the function to paginate in clients detail the tabs for quotes invoices and payments
Related Issue
#1083
Motivation and Context
If a client have more than 20 invoices, payments or quotes, only the newest 20 was shown
Pull Request Checklist
Issue Type (Please check one or more)