Add pool operator extended key support #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
e5fe0be to
9aac6c3
Compare
9aac6c3 to
d68d3b5
Compare
Jimbo4350
requested changes
Mar 26, 2025
6b13e0b to
1835032
Compare
Jimbo4350
requested changes
Apr 10, 2025
Contributor
Jimbo4350
left a comment
There was a problem hiding this comment.
Have you created an operational certificate with an extended key and tried to deserialise it from disk?
7e83e51 to
2005d0c
Compare
Jimbo4350
requested changes
Apr 22, 2025
Jimbo4350
approved these changes
Apr 23, 2025
Contributor
Jimbo4350
left a comment
There was a problem hiding this comment.
LGTM! Squash the commits.
2005d0c to
a47eeb8
Compare
gitmachtl
added a commit
to gitmachtl/CIPs
that referenced
this pull request
May 13, 2025
https://cips.cardano.org/cip/CIP-0005 does not specify bech32 prefixes for extended pool operator keys. These were added to cardano-api with IntersectMBO/cardano-api#781 and part of cardano-cli with IntersectMBO/cardano-cli#1091 This PR modifies CIP-0005 to define a standard set of prefixes for them. Other changes: - Added [https://github.com/gitmachtl/cardano-signer](cardano-signer) to the list of tools (acceptance criteria) - Added an entry in the Changelog table
rphair
pushed a commit
to cardano-foundation/CIPs
that referenced
this pull request
May 20, 2025
) * CIP-0005 | Define bech32 prefixes for extended pool operator keys https://cips.cardano.org/cip/CIP-0005 does not specify bech32 prefixes for extended pool operator keys. These were added to cardano-api with IntersectMBO/cardano-api#781 and part of cardano-cli with IntersectMBO/cardano-cli#1091 This PR modifies CIP-0005 to define a standard set of prefixes for them. Other changes: - Added [https://github.com/gitmachtl/cardano-signer](cardano-signer) to the list of tools (acceptance criteria) - Added an entry in the Changelog table * Update README.md * Edited the `Changelog table` so IDs are in decreasing order (newest on top)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Tries to address #668.
Check together with: IntersectMBO/cardano-cli#1091
How to trust this PR
Look at the test for creating stake pool registration certificate using an extended cold key. Make sure the refactorings preserve the logic of the code and that the extensions make sense. Check the code structure is good and documentation is appropriate.
Checklist