Merged
Conversation
luisremis
previously approved these changes
Mar 27, 2019
Contributor
luisremis
left a comment
There was a problem hiding this comment.
lgtm! I would change the name of the test tho. "EntityBug" does not tell anything.
Contributor
|
Also, it would be great to have python tests for this kind of bug fixes, even if similar to the unit tests you have for c++ |
Contributor
Author
|
Do you want me to merge this fix before the VCL changes or after? |
Contributor
|
Looks good to go! Conflicts should be straight forward to fix. Either adding and extra commit for the conflict fix or amending the last commit (with the tests cases) should be fine. |
If no _ref is used, an empty search result is fine. However, there is still an error if no results are found using the given constraints and there is a _ref value used.
Contributor
Author
|
Should be good to merge now. Take a look. Passes on my system with the new test hierarchy. |
luisremis
approved these changes
Mar 29, 2019
cwlacewe
added a commit
to cwlacewe/vdms
that referenced
this pull request
Apr 14, 2023
* Format CMakeLists.txt * Add CSV CPP Client Plugin * Fix the VDMS path dependencies in csv_plugin library * Add the multithread layer class in CSVParser class that uses the utilities in CSVPArserUtil.cpp and add the test in tests folder * merge csv plugin in cleint folder * Update check-in Dockerfiles to include lib * Add the csv-plugin as CSVParser in the VDMS::Client CPP folder as a utility * Remove COpy csv-cpp-lib * fix the failing tests * adjust run python_tets * fix the stash conflict * wprking on csv tests * Working os csv tests * Update run_coverage_cpp.sh Include .cpp files * Update run_coverage_cpp.sh Add flag to overcome known error (https://gcovr.com/en/master/guide/gcov_parser.html#negative-hit-counts) * stash changes * Configue the prot of csv parser * Trying to add the video tesing in csv * Fi the test script * fix run_python_test * Uncoment the Update in CSV * Csv client lib (IntelLabs#95) * Update python coverage test to exclude tests folder * Remove unused old folder (csv-cpp-lib), remove hardcoded ragaad paths from CMakeLists files, remove commented code * Fix splitrow, add bin to supported image format, uncomment constraints for images, use CSVformat100.csv for entity test, add operations to image and video csv * Update tests/unit_tests/client_add_entity.cc Removed empty line (only change to file) * Update CMakeLists.txt Remove empty line (only change to file) * Update tests/main.cc remove empty line * Csv client lib (IntelLabs#96) * Fix ops in video csv, update csvs for additional testing, improve isInt * Add additional tests and catch case for unkonwn commandtype * Update tests/main.cc --------- Co-authored-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to some reported issues like error on empty results