Conversation
Contributor
|
Does this also remove the folder these files are in? Those were the only two files in that folder |
Contributor
|
There is also still RWLock.h and arch.h files which I think are not needed anymore. YOu can change this one to code cleanup branch and put two commits as far as I can tell right now |
vishakha041
suggested changes
Jan 30, 2019
Contributor
vishakha041
left a comment
There was a problem hiding this comment.
Remove hte examples folder and add another commit to remove RWLock + arch.h in src/. I didn't see other unnecessary stuff lying around but worth a quick scan
Contributor
Author
|
Good suggestion. I removed those files as well. |
Contributor
Author
Yes, it does. |
vishakha041
approved these changes
Jan 31, 2019
cwlacewe
added a commit
to cwlacewe/vdms
that referenced
this pull request
Apr 14, 2023
…ntelLabs#77) * Generate buffer code for python client, update coverage workflow to include python code * Skip failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.