Conversation
0778031 to
584c749
Compare
vishakha041
previously approved these changes
Nov 1, 2018
Contributor
vishakha041
left a comment
There was a problem hiding this comment.
Do split the commits where needed and maybe name the branch better? :)
| @@ -0,0 +1,256 @@ | |||
| # | |||
| # The MIT License | |||
Contributor
There was a problem hiding this comment.
Could you please split out the test commit.
src/DescriptorsCommand.cc
Outdated
| if (cache.isMember("cache_obj_id")) { | ||
| // TODO CHECK THIS UNSAFE ERASE | ||
| _cache_map.unsafe_erase(cache["cache_obj_id"].asInt64()); | ||
| // _cache_map.unsafe_erase(cache["cache_obj_id"].asInt64()); |
Contributor
There was a problem hiding this comment.
Any reason you have this line commented out? If not needed, just remove it
| for i in range(0,concurrency): | ||
| thread_add = Thread(target=self.addEntity,args=(i, results) ) | ||
| thread_add.start() | ||
| thread_arr.append(thread_add) |
Contributor
There was a problem hiding this comment.
What are these set of changes for? I am lazy to figure it out myself :) seems like a different commit from a quick scan.
Contributor
Author
There was a problem hiding this comment.
stuff for checking that concurrent read/writes worked. you only need to worry about it if the test fails :)
584c749 to
ca6523f
Compare
Ragaad
pushed a commit
to Ragaad/vdms
that referenced
this pull request
Jun 16, 2022
* Adding FLINNG Library * Add the default value of parameters of the Flinng descriptor Set * Update both dockerfiles to match (other than coverage) * remove parma value from Flinngvoid FlinngDescriptorSet::getFlinngParams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37 , #33.