Conversation
vishakha041
previously approved these changes
Jul 1, 2019
Contributor
vishakha041
left a comment
There was a problem hiding this comment.
Good catch. I didn't even know we were forcing that. Hmmm. Did you update the wiki already?
Contributor
|
Only small concern here, shouldn't png be default since it is lossless? Or more like, set it to whatever the original is?? |
TDB format only perform better with large images, and is usually not the first choice for users, forcing them to explicitly change for format for every insertion or getting error messages. It is better to just go with JPG as the default.
Contributor
Author
|
sounds good, we can switch to use the original format or the image. Fixed and all tests passing, wiki updated. As a future enhancement (#73 ), if the user does not specify a change of format nor operations, we need to write the image directly. |
vishakha041
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDB format only performs better with very large images, and it is usually not the first choice for users, forcing them to explicitly change for format for every insertion or getting error messages. It is better to just go with JPG as the default until we start seeing more use cases showing the benefits of the format.