Conversation
|
I'll look at this once we close the other PR. I believe this is based off of that one. |
|
@vishakha041, these are independent, as you can see following the commits. So you can go ahead and review it. |
vishakha041
left a comment
There was a problem hiding this comment.
I think it might be better to do the Operator change before this one so you can have a cleaner version of FindFrames and remove your comment about the hack.
This is a quick review for some things that were noticeable.
ffc3f81 to
694e7ef
Compare
|
All comments addressed. Good to go for me! |
|
I've just did an interactive rebase on all three patches to sign them off. All the changes look good to me. |
…ublic Signed-off-by: mahircg <mahircan.guel@intel.com>
Signed-off-by: mahircg <mahircan.guel@intel.com>
Signed-off-by: mahircg <mahircan.guel@intel.com>
|
Created a separate commit for fixing a bug in Video command response. Should be good to go. |
vishakha041
left a comment
There was a problem hiding this comment.
If the comments do not indicate a problem, then this looks fine.
* Fix CIDs 3428250, 3399517, 3399721 * Fix CID 3399499 * Fix CIDs 3399722 and 3399506 * Fix CID 3399609 and 3399442 * Fix CID 3399441 * Fix 3399465 and 3399606 * fix 3399466 * Fix CID 3399404 and 3399679 * Fix CID 3441993 Signed-off-by: tmcourie <taylor.courier@intel.com> Co-authored-by: tmcourie <taylor.courier@intel.com> Co-authored-by: Ragaad <ragaad.altarawneh@intel.com>
This patch introduces 'FindFrames' command, that searches for the given
video name and returns a list of frames from the video if it is found.
Currently, FindFrame command relies on OpenCV's frame iteration
capabilities. Thus, the entire video is loaded into memory to be
decoded. In future, the video loading and decoding should be done only
on the requested frame interval.
Signed-off-by: mahircg mahircan.guel@intel.com