Skip to content

Add docker files#1

Merged
luisremis merged 1 commit intomasterfrom
add_docker
Feb 22, 2018
Merged

Add docker files#1
luisremis merged 1 commit intomasterfrom
add_docker

Conversation

@luisremis
Copy link
Copy Markdown
Contributor

Adding the docker file to build a docker image of VDMS, and a README.

crstrong
crstrong previously approved these changes Feb 22, 2018
Copy link
Copy Markdown
Contributor

@crstrong crstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -0,0 +1,21 @@
# VDMS Docker

The build command is:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify that this is for building the server only? I'd like to think people are smart enough to figure that out, but ...

If we mention it somewhere else (like in the main README), that's also probably fine

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that to the README here, just in case.

Copy link
Copy Markdown
Contributor

@crstrong crstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good

@vishakha041
Copy link
Copy Markdown
Contributor

Wonderful

@luisremis luisremis merged commit 6d3361a into master Feb 22, 2018
@luisremis luisremis deleted the add_docker branch February 22, 2018 23:26
omp87 added a commit to omp87/vdms-1 that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants