BUG: Fix computation of weighted centroid in LabelGeometryImageFilter#4530
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom Mar 20, 2024
Merged
Conversation
Intensity values were cast to integers, thus making the computation imprecise.
Member
|
The changes look OK. Just an FYI, not all attributes of LabelGeometryImageFilter take into consideration image spacing and geometry. The similar LabelMap based statistics I have found to be reliable. |
Member
Author
|
The above used image has unit spacing, so that is not the issue. |
Use real-typed variable for the accumulation.
thewtex
approved these changes
Mar 20, 2024
dzenanz
added a commit
to dzenanz/ITK
that referenced
this pull request
Apr 29, 2024
This filter is buggy, and sometimes produces wrong results. Follow-up to: InsightSoftwareConsortium#4530
3 tasks
dzenanz
added a commit
to dzenanz/ITK
that referenced
this pull request
Apr 29, 2024
This filter is buggy, and sometimes produces wrong results. Follow-up to: InsightSoftwareConsortium#4530
dzenanz
added a commit
that referenced
this pull request
Apr 29, 2024
This filter is buggy, and sometimes produces wrong results. Follow-up to: #4530
bourdaisj
pushed a commit
to bourdaisj/ITK
that referenced
this pull request
May 15, 2024
This filter is buggy, and sometimes produces wrong results. Follow-up to: InsightSoftwareConsortium#4530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intensity values were cast to integers, thus making the computation imprecise.
Images below show centroids in red and weighted centroids in green.
Before this PR:
After this PR:
PR Checklist