Merged
Conversation
Inokinoki
pushed a commit
that referenced
this pull request
Dec 28, 2025
This commit renames QEFIPartitionInfo to QEFIPartitionScanInfo to avoid naming conflicts with PR #45's QEFIPartitionInfo struct, which serves a different purpose (high-level partition management vs. low-level scanning with byte offsets). Changes: - Rename QEFIPartitionInfo → QEFIPartitionScanInfo in: * qefipartitionscanner.h/cpp * qefifileselectiondialog.h/cpp * qefiloadoptioneditorview.cpp - Add documentation explaining the difference: * QEFIPartitionScanInfo (ours): Low-level partition scan data with byte offsets for direct filesystem access * QEFIPartitionInfo (PR #45): High-level partition metadata for mounting/unmounting through OS - Add INTEGRATION_WITH_PR45.md documenting: * How the two features complement each other * Different approaches (mounting vs. direct access) * Benefits of each approach * Future integration opportunities The two features work independently but complement each other: - PR #45: General EFI partition management (mount/unmount, view properties) - Our implementation: Boot entry creation workflow (browse & select EFI files) No conflicts exist as they use different source files and struct names. Both require admin/root privileges and work cross-platform.
… device enumeration and error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to list, mount, unmount and open a partition. Close #9