Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=====================================
Coverage 2.11% 2.11%
=====================================
Files 34 34
Lines 2083 2080 -3
=====================================
Hits 44 44
+ Misses 2039 2036 -3 ☔ View full report in Codecov by Sentry. |
|
@karel-rehor, the Codecov report isn't applicable in this case due to the refactoring of the file styles. |
There was a problem hiding this comment.
Ran this example against an initial user account - it eventually resulted in the following error
The retriable error occurred during request. Reason: 'org fbb67cd4c8905be6 has exceeded limited_write plan limit'. Retry in 206s.
While a good example of batching, I'm not sure from perhaps a marketing perspective, if it is a good example for newer users.
There was a problem hiding this comment.
Tried this example as well against a new user account. Apparently the "flight2" bucket needs to be created in another example.
Failed with error
pyarrow.lib.ArrowInvalid: Flight returned invalid argument error, with message: bucket "flight2" not found. gRPC client debug context: UNKNOWN:Error received from peer ipv4:34.196.233.7:443 {created_time:"2024-04-05T10:59:19.006603056+02:00", grpc_status:3, grpc_message:"bucket \"flight2\" not found"}. Client context: IOError: Server never sent a data message. Detail: Internal
karel-rehor
left a comment
There was a problem hiding this comment.
- Tests pass. Could be more of them.
- Linter (flake8) passes.
- Tried running a few examples but they have issues.
- Not self contained - some expect a prepared database state
- One exceeded limits for introductory account
- Some use outdated API, which has been refactored
- Still with a few changes they can be executed
- For these issues Enhancement Request #82 has been opened
Since this PR is basically about standardizing code style and removing detritus like unused import statements, it should not be necessary to address issues with examples here.
Good to go.
Proposed Changes
This PR enable CI check for source file code style checking.
Checklist