Minor update, added get/set on a protected variable#138
Merged
PierreFonda3D merged 2 commits intomainfrom Mar 5, 2025
Merged
Conversation
epernod
reviewed
Mar 3, 2025
| return 0; | ||
| } | ||
|
|
||
| public Mesh GetMesh() |
Contributor
There was a problem hiding this comment.
Suggested change
| public Mesh GetMesh() | |
| /// Getter: returns Unity Mesh object attached to the MeshFilter of this GameObject | |
| public Mesh GetMesh() |
epernod
requested changes
Mar 3, 2025
| return m_mesh; | ||
| } | ||
|
|
||
| public void SetMesh(Mesh mesh) |
Contributor
There was a problem hiding this comment.
Suggested change
| public void SetMesh(Mesh mesh) | |
| /// Setter: Method to set Mesh attached to the MeshFilter of this GameObject | |
| public void SetMesh(Mesh mesh) |
|
|
||
| public void SetMesh(Mesh mesh) | ||
| { | ||
| m_mesh=mesh; |
Contributor
There was a problem hiding this comment.
Suggested change
| m_mesh=mesh; | |
| m_mesh = mesh; | |
| MeshFilter mf = gameObject.GetComponent<MeshFilter>(); | |
| if (mf != null) | |
| { | |
| mf.mesh = m_mesh; | |
| } |
epernod
requested changes
Mar 5, 2025
Contributor
epernod
left a comment
There was a problem hiding this comment.
@PierreFonda3D did you see my reviews?
PierreFonda3D
added a commit
that referenced
this pull request
Mar 5, 2025
Minor update, added get/set on a protected variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SofaVisualModel: added getter and setter for a protected variable, making it useful for sphere mapping on Sofa Objects.