Ignoring npm files #2313
Merged
Ignoring npm files #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
mark9064
approved these changes
Jun 14, 2025
Member
mark9064
left a comment
There was a problem hiding this comment.
Perhaps we should ship a package-lock to make installs more reproducible but this is certainly an improvement compared to the git tree disaster node_modules creates at the moment
Contributor
Author
|
Fair enough, I don't know that much about npm or package-lock, but figured we'd want to avoid committing them. |
NeroBurner
approved these changes
Jun 18, 2025
JustScott
pushed a commit
to JustScott/InfiniTime
that referenced
this pull request
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files created from npm to .gitignore