Show shake calibration being disabled when in sleep mode #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eep mode (cherry picked from commit 1d25b7b)
- Switch from bool EnableForCal to always saving and restoring shake wake mode to avoid to many conditionals in the constructor and destructor - Refactor calibrating into currentCalibrationStepEnum with descriptive names - Initialize variables with default values in the class body - Switch to forward declarations for references in the header and remove unused include - Fix issue where text would stay on screen due to not calling lv_obj_clean() in the destructor (cherry picked from commit af30390)
|
Build size and comparison to main:
|
Member
|
After #2328 it now works all the time :) thanks for writing up this feature nonetheless The refactoring you've done still looks good though, if you would like to open a new PR for that I will try and take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by the issue with the shake calibration on my PineTime for which a partial fix exists in #2161 (thank you lmamane). I adopted those changes and made the suggested enum refactor as well as fixed an issue with the text not disappearing when leaving the shake calibration screen.
Here is a screenshot of the new disabled message:
All changes are: