Skip to content

Conversation

@lmamane
Copy link
Contributor

@lmamane lmamane commented Nov 6, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 6, 2024

Build size and comparison to main:

Section Size Difference
text 374768B 176B
data 948B 0B
bss 63504B 0B

@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Nov 18, 2024
@mark9064
Copy link
Member

This all looks good, but I think the calibrating variable should be refactored into a state enum instead as it's currently somewhat unintuitive and the 255 value doesn't help. Perhaps something like States {Idle, PrepareToCalibrate, Calibrating, CalibrationDisabled}? These probably aren't the best names, I haven't thought about them much. Hopefully you get the idea though

@dariusarnold
Copy link
Contributor

dariusarnold commented Mar 12, 2025

This also has the issue that the text stays on the screen behind the other menu items if you leave the shake calibration screen since lv_obj_clean() is not called.

@lmamane
Copy link
Contributor Author

lmamane commented Jun 11, 2025

Pull request #2268 enhances and replaces this one.

@lmamane lmamane closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to an existing app/feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants