Notification -> Notifications #2238
Conversation
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
|
Build size and comparison to main:
|
FintasticMan
left a comment
There was a problem hiding this comment.
Somehow, I haven't noticed this before!
|
I read the singular as: I also read the specific case for Notification 0/0 as the notification that you are currently on so the area which would normally display the notification singularly says (correctly in my opinion) "No notification to display". It's only my opinion and would save 16B. |
|
I agree that either "Notification" or "Notifications" is in some way not perfectly descriptive. Something like "Notification Center" would be ideal, but it doesn't fit inside that space. |
mark9064
left a comment
There was a problem hiding this comment.
I also agree that this isn't optimal, but that it fits better with the s than without. May as well merge this for now, and then if someone suggests a better idea later on we can switch to it
Change the "No notification" text to "No notifications"
Change the "No notification" text to "No notifications"
Change the "No notification" text to "No notifications"
This PR is a small change and it might very well be up to preference.
In the little notifications screen above the watchface, the "Notification" as well as "No notification to display" is now changed to "Notifications" and "No notifications to display".
In my opinion using the plural makes more sense here, since the screen can show more than just one notification.
Feel free to tell me what you think!
Here's a pic of how it looks like in InfiniEmu:
