Skip to content

Center text on timer button #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minacode merged 15 commits into from
May 16, 2025
Merged

Center text on timer button #2229

minacode merged 15 commits into from
May 16, 2025

Conversation

@tituscmd
Copy link
Contributor

@tituscmd tituscmd commented Jan 18, 2025 •
edited
Loading

Hey everybody!

This PR is made to center the "Start"/"Pause" text on the button in the timer app. The previous implementation created the text object and aligned it to the button object, this implementation creates the text object with a pointer to the button object and thus makes it centered at all times!

Here's a screenshot of InfiniEmu running it:
Screenshot_2025-01-18_15-29-43

@github-actions
Copy link

github-actions bot commented Jan 18, 2025 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 375812B -16B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@tituscmd tituscmd changed the title Center timer button correctly Center text on timer button Jan 18, 2025
@mark9064 mark9064 added enhancement Enhancement to an existing app/feature maintenance Background work labels Jan 23, 2025
mark9064
mark9064 reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a nicer way to do it

@mark9064 mark9064 added this to the 1.16.0 milestone Feb 14, 2025
@minacode
Copy link
Contributor

minacode commented May 14, 2025

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.

@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.

@tituscmd
Copy link
Contributor Author

tituscmd commented May 14, 2025

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.

@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.

I'll be home in about 15 minutes and then I'll do that for sure! 🙂

@tituscmd
Copy link
Contributor Author

tituscmd commented May 14, 2025 •
edited
Loading

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.
@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.

I'll be home in about 15 minutes and then I'll do that for sure! 🙂

I guess that 15 minutes was quite the underestimate 😅
Should be all done now!

@minacode minacode merged commit bb8923b into InfiniTimeOrg:main May 16, 2025
7 checks passed
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@tituscmd @JustScott
Center text on timer button (InfiniTimeOrg#2229)
2ac23c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes

@minacode minacode minacode approved these changes

@mark9064 mark9064 mark9064 approved these changes

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tituscmd @minacode @JF002 @mark9064