Remove the vibration while charging #1768
Conversation
This fixes a bug where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.
|
Build size and comparison to main:
|
|
I like this, I have experienced this problem many times. But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging? |
Nice :) It seems to be a common issue.
I think that would belong to another PR. This one is only about removing the bug. |
|
That's not a problem I have had on the sealed watch, but the vibration is very loud. |
|
Just FYI there is also #1876 |
|
Which I like even more! 😄 I hope your gets merged. We can close this one if it did. |
|
I do like the tactility though, what about only doing the vibration if there hasn’t been a charging event in the last ~1 minute? |
|
I will keep this PR as simple as possible and just remove the one line. |
mark9064
left a comment
There was a problem hiding this comment.
I think it also makes sense to remove the charging event from displayapp as apps pull charging state directly from the batterycontroller; after this change the message would be unused.
|
Totally. I removed it. |
This fixes #724 where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.