Open battery app when charging #1876
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
This might be better as kind of popup, like a notification with that 5 second timeout. |
vkareh
approved these changes
Jan 30, 2024
Contributor
vkareh
left a comment
There was a problem hiding this comment.
I like the simplicity of this code. Doesn't add much overhead and works well (have been using it for a few months with no issues) while improving user expectation upon plugging/unplugging.
Contributor
|
I've included this patchset as part of a larger configuration that allows auto-opening apps based on certain events: https://github.com/InfiniTimeOrg/InfiniTime/pull/2004/commits This makes this feature optional/configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the battery info app open upon putting the watch on the charger, if the current app is the clock (as to not close any app that might be running). If the watch is taken off the charger while the battery app is open, it returns to the clock.
This pr also removes the vibration while charging if the battery app is opened/closed, which should help prevent #724.