Skip to content

circularbuffer: Add circular buffer utility struct #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FintasticMan wants to merge 1 commit into from
Closed

circularbuffer: Add circular buffer utility struct #1696

FintasticMan wants to merge 1 commit into from

Conversation

@FintasticMan
Copy link
Member

@FintasticMan FintasticMan commented Mar 17, 2023 •
edited
Loading

Implements a simple circular buffer template. buf[0] is the value at the current index. You can use the ++ and -- operators to move the index. You can initialise the buffer using aggregate initialisation, meaning you can just initialise with a curly-brace list.

@FintasticMan FintasticMan mentioned this pull request Mar 17, 2023
Open
@github-actions
Copy link

github-actions bot commented Mar 17, 2023 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 409268B 0B
data 996B 0B
bss 63356B 0B

@FintasticMan FintasticMan added the maintenance Background work label Mar 17, 2023
@FintasticMan FintasticMan requested a review from a team March 17, 2023 22:40
@FintasticMan FintasticMan changed the title circularbuffer: Add circular buffer utility struct circularbuffer: Add circular buffer utility struct and switch NotificationManager to use it Mar 20, 2023
@FintasticMan
Copy link
Member Author

FintasticMan commented Mar 20, 2023 •
edited
Loading

I've just pushed a change that switches NotificationManager to use this new CircularBuffer. IMO it makes the code easier to understand from a glance.

@Riksu9000
Copy link
Contributor

Riksu9000 commented Mar 22, 2023 •
edited
Loading

Maybe a static sized vector class is more along the lines of what we need for NotificationManager, along with a helper function that will erase the oldest entry if pushing a new element wouldn't fit otherwise.

See #1712

@FintasticMan FintasticMan mentioned this pull request Apr 1, 2023
Merged
@FintasticMan FintasticMan changed the title circularbuffer: Add circular buffer utility struct and switch NotificationManager to use it circularbuffer: Add circular buffer utility struct Jun 17, 2023
@FintasticMan FintasticMan mentioned this pull request Jun 17, 2023
Merged
@FintasticMan
Copy link
Member Author

FintasticMan commented Aug 17, 2023

Merged with #826.

@FintasticMan FintasticMan added this to the 1.14.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@FintasticMan @Riksu9000