Skip to content

Conversation

@Riksu9000
Copy link
Contributor

@Riksu9000 Riksu9000 commented Mar 29, 2023

Apart from renaming some public functions to reduce ambiguity, this does not change the behavior of the class IndexOf won't return an invalid index anymore, so there are minor differences in (unused) edge cases Reverted so Get() can return an empty notification if the id is invalid.. Using a vector-like class makes it so the newest element has the highest index, whereas before At(0) was the newest entry. A new function was added to get the position of the notification where 0 is the newest one, to imitate the behavior of the old previously public IndexOf() function.

@Riksu9000 Riksu9000 added the maintenance Background work label Mar 29, 2023
@Riksu9000 Riksu9000 requested review from a team and FintasticMan March 29, 2023 08:39
@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Build size and comparison to main:

Section Size Difference
text 406244B -244B
data 940B 0B
bss 53552B -8B

Rename some public NotificationManager functions to reduce ambiguity
@Riksu9000 Riksu9000 closed this by deleting the head repository Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Background work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant