Add StaticVector for NotificationManager #1712
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from renaming some public functions to reduce ambiguity,
this does not change the behavior of the classIndexOf won't return an invalid index anymore, so there are minor differences in (unused) edge casesReverted so Get() can return an empty notification if the id is invalid.. Using a vector-like class makes it so the newest element has the highest index, whereas beforeAt(0)was the newest entry. A new function was added to get the position of the notification where 0 is the newest one, to imitate the behavior of the old previously public IndexOf() function.