Skip to content

add CMake include and use its list for fonts #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yehoshuapw wants to merge 1 commit into from
Closed

add CMake include and use its list for fonts #28

yehoshuapw wants to merge 1 commit into from

Conversation

@yehoshuapw
Copy link

@yehoshuapw yehoshuapw commented Apr 28, 2022

Add method to work with InfiniTimeOrg/InfiniTime#1097
to CMake files.

@yehoshuapw yehoshuapw mentioned this pull request Apr 28, 2022
Merged
@yehoshuapw
Copy link
Author

yehoshuapw commented Apr 28, 2022

I didn't realize in advance (never really used CMake before. always used plain make) that creating a variable will make it global,
so if you disapprove of the naming - I can change things in both places.

@JF002 JF002 self-requested a review April 30, 2022 20:19
@JF002
Copy link
Contributor

JF002 commented May 10, 2022

I've just tried these changes but it doesn't seem to work for me :/

[100%] Linking CXX executable infinisim
/usr/bin/ld: CMakeFiles/infinisim.dir/home/jf/git/PineTime/src/displayapp/screens/WatchFaceDigital.cpp.o: warning: relocation against `jetbrains_mono_extrabold_compressed' in read-only section `.text'
/usr/bin/ld: CMakeFiles/infinisim.dir/main.cpp.o: in function `hal_init()':
/home/jf/git/InfiniSim/main.cpp:871: undefined reference to `jetbrains_mono_bold_20'
/usr/bin/ld: /home/jf/git/InfiniSim/main.cpp:871: undefined reference to `jetbrains_mono_bold_20'
/usr/bin/ld: /home/jf/git/InfiniSim/main.cpp:871: undefined reference to `jetbrains_mono_bold_20'
/usr/bin/ld: /home/jf/git/InfiniSim/main.cpp:871: undefined reference to `jetbrains_mono_bold_20'
/usr/bin/ld: CMakeFiles/infinisim.dir/home/jf/git/PineTime/src/libs/lvgl/src/lv_core/lv_obj.c.o: in function `lv_init':
/home/jf/git/PineTime/src/libs/lvgl/src/lv_core/lv_obj.c:207: undefined reference to `jetbrains_mono_bold_20'
<<And many more errors>>

I'm not a CMake Guru either, but here's something we can try if your solution does not work : Implement the font generate Cmake code in a CMake function in a new file. Pass "source" and "output" directories as parameters to this function. Then, we should be able to include the function and to call this function from both InfiniTime and InfiniSim with correct arguments.

@NeroBurner
Copy link
Collaborator

NeroBurner commented May 15, 2022

closed in favor of #29

But thank you for the PR and the time you spent 🙇

@NeroBurner NeroBurner closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 Awaiting requested review from JF002

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yehoshuapw @JF002 @NeroBurner