Use infinitime_fonts target if fonts/CMakeLists.txt exists #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems to fail when using an external InfiniTime repo, because it's not a subdirectory of InfiniSim. |
NeroBurner
commented
May 11, 2022
yehoshuapw
approved these changes
May 11, 2022
yehoshuapw
left a comment
There was a problem hiding this comment.
I didn't check to make sure it works, since it seems that has been done already - but looks good.
thanks!
JF002
approved these changes
May 14, 2022
Contributor
JF002
left a comment
There was a problem hiding this comment.
It works for me, both on the "older" develop branch (when the fonts were not generated by cmake) and with the new one (with font generated by cmake)!
Since InfiniTimeOrg/InfiniTime#1097 the fonts are generated. Support this new way of using fonts. When InfiniTime isn't a subdirectory of InfiniSim we need to provide the binary dir when using `add_subdirectory()`. Use `fonts`. Update README with instructions to install `lv_font_conv`.
7c938b0 to
594cd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since InfiniTimeOrg/InfiniTime#1097 the fonts
are generated. Support this new way of using fonts.