This repository was archived by the owner on May 22, 2026. It is now read-only.
refactor: replace futures-async-stream with stable alternative asynk-strim#153
Merged
Conversation
…nk-strim` Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Code Review
This pull request replaces the futures-async-stream dependency with asynk-strim-attr across the project, enabling the removal of the unstable coroutines feature. All asynchronous stream functions have been refactored to use the TryYielder pattern for emitting events. Feedback was provided regarding the use of a git dependency for asynk-strim-attr, suggesting that vendoring the code might be a safer alternative to ensure build reproducibility and security.
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This was referenced May 4, 2026
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 13, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 13, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 13, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 19, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 21, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 21, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to BugenZhao/vllm
that referenced
this pull request
May 21, 2026
…nk-strim` (Inferact/vllm-frontend-rs#153) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can get rid of the unstable
coroutineslanguage feature in favor of switching to the stable toolchain.asynk-strimitself is macro-free, but this PR uses an attr libraryasynk-strim-attrfor minimal changes & indents.