Skip to content

feat(annotations): annotation-less arguments, and description mappers#551

Merged
Citymonstret merged 5 commits into2.0.0-devfrom
feature/2.0.0/arguments-without-annotations
Dec 8, 2023
Merged

feat(annotations): annotation-less arguments, and description mappers#551
Citymonstret merged 5 commits into2.0.0-devfrom
feature/2.0.0/arguments-without-annotations

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

@Citymonstret Citymonstret commented Dec 8, 2023 •
edited
Loading 

@CommandMethod("command <required> [optional] [optional_but_weird]")
public void command(TestCommandSender sender, String required, Integer optional, Boolean optionalButWeird) {
}

@Citymonstret Citymonstret added this to the 2.0.0 milestone Dec 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2023 •
edited
Loading

Test Results

  75 files  +2    75 suites  +2   13s ⏱️ -7s
464 tests +3  464 ✔️ +3  0 💤 ±0  0 ❌ ±0 
476 runs  +3  476 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 62ff751. ± Comparison against base commit 77a44d4.

♻️ This comment has been updated with latest results.

Citymonstret pushed a commit that referenced this pull request Dec 8, 2023
feat(annotations): add @Default
27c5760 
We're making the annotations more flexible, and #551 makes the presence of `@Argument` optional. It would be
convenient to be able to provide default values even when the `@Argument` annotation is not present.
@Citymonstret Citymonstret mentioned this pull request Dec 8, 2023
Merged
Alexander Söderberg added 5 commits December 8, 2023 17:20
feat(annotations): annotation-less arguments, and description mappers
99f35f9 
```java
@CommandMethod("command <required> [optional] [optional_but_weird]")
public void command(TestCommandSender sender, String required, int optional, boolean optionalButWeird) {
}
```
fix the annotation processor
1ea4250
spice up the README
528e8ca
weird newlines be gone
f04d5f5
move @Default handling into StandardArgumentExtractor
62ff751
@Citymonstret Citymonstret force-pushed the feature/2.0.0/arguments-without-annotations branch from 03e3e3d to 62ff751 Compare December 8, 2023 16:22
@Citymonstret Citymonstret mentioned this pull request Dec 8, 2023
Closed
@Citymonstret Citymonstret merged commit fb13213 into 2.0.0-dev Dec 8, 2023
@Citymonstret Citymonstret deleted the feature/2.0.0/arguments-without-annotations branch December 8, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@powercasgamer powercasgamer powercasgamer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Cloud 2.0
Status: Done

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Citymonstret @powercasgamer