Skip to content

feature(minecraft): support Brigadier tooltips #533

Merged
Citymonstret merged 6 commits intofeature/2.0.0/generic-suggestionsfrom
feature/2.0.0/brig-tooltips
Nov 30, 2023
Merged

feature(minecraft): support Brigadier tooltips #533
Citymonstret merged 6 commits intofeature/2.0.0/generic-suggestionsfrom
feature/2.0.0/brig-tooltips

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

@Citymonstret Citymonstret commented Nov 30, 2023

This builds on top of #529.

Paper will accept tooltip suggestions when using Brigadier. Because of potential adventure relocation we're forced to use awful reflection to set the tooltips (because the paper API only accepts components, not messages 😢). Velocity & Fabric get nice mappings.

@Citymonstret Citymonstret added this to the 2.0.0 milestone Nov 30, 2023
@Citymonstret Citymonstret changed the title feat: allow for generic suggestions feature(minecraft): support Brigadier tooltips Nov 30, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 30, 2023

Test Results

  69 files  ±0    69 suites  ±0   14s ⏱️ -2s
447 tests ±0  447 ✔️ ±0  0 💤 ±0  0 ±0 
459 runs  ±0  459 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 57b9e50. ± Comparison against base commit 4e4fb57.

♻️ This comment has been updated with latest results.

@Citymonstret Citymonstret marked this pull request as ready for review November 30, 2023 10:54
@Citymonstret Citymonstret force-pushed the feature/2.0.0/brig-tooltips branch from 10e8cf9 to 994fe17 Compare November 30, 2023 11:43
@Citymonstret Citymonstret merged commit b9720f3 into feature/2.0.0/generic-suggestions Nov 30, 2023
@Citymonstret Citymonstret deleted the feature/2.0.0/brig-tooltips branch November 30, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant