feat: allow for generic suggestions & add tooltips#529
Merged
Citymonstret merged 5 commits into2.0.0-devfrom Nov 30, 2023
Merged
feat: allow for generic suggestions & add tooltips#529Citymonstret merged 5 commits into2.0.0-devfrom
Citymonstret merged 5 commits into2.0.0-devfrom
Conversation
This forces all suggestions to go through the suggestion factory (previously engine). This means that we do not have to pollute the entire codebase with yet another generic parameter (CommandManager is used in MANY places) that we generally do not need to care about. The platforms can override the suggestion factory method and work with a sub-type of suggestion. This is in preparation for tooltip support (see #66)
# Conflicts: # cloud-minecraft/cloud-brigadier/src/main/java/cloud/commandframework/brigadier/CloudBrigadierManager.java
added 2 commits
November 30, 2023 16:30
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forces all suggestions to go through the suggestion factory (previously engine). This means that we do not have to pollute the entire codebase with yet another generic parameter (CommandManager is used in MANY places) that we generally do not need to care about.
The platforms can override the suggestion factory method and work with a sub-type of suggestion.
This is in preparation for tooltip support (see #66)